FINERACT-2421: Loan product basic detail endpoint#5569
Open
alberto-art3ch wants to merge 1 commit intoapache:developfrom
Open
FINERACT-2421: Loan product basic detail endpoint#5569alberto-art3ch wants to merge 1 commit intoapache:developfrom
alberto-art3ch wants to merge 1 commit intoapache:developfrom
Conversation
a3508d5 to
f358c00
Compare
f358c00 to
60e9f8a
Compare
adamsaghy
reviewed
Mar 2, 2026
| private static final String RESOURCE_NAME_FOR_PERMISSIONS = "LOANPRODUCT"; | ||
| private final PlatformSecurityContext context; | ||
| private final LoanProductReadPlatformService loanProductReadPlatformService; | ||
| private final WorkingCapitalLoanProductReadPlatformService workingCapitalLoanProductReadPlatformService; |
Contributor
There was a problem hiding this comment.
Create a new interface (like LoanProductReadBasicDetailsService) in the fineract-loan module which has the retrieveProducts() method.
Lets have 2 implementation of this interface:
- in
fineract-loanmodule which return those loan products - in
fineract-working-capital-loanmodule which return those loan products
This class also can be moved into fineract-loan module.
We dont need to explicitly inject LoanProductReadPlatformService and WorkingCapitalLoanProductReadPlatformService.
Lets inject List of the newly created interface:
private final List<LoanProductReadBasicDetailsService> loanProductReadBasicDetailsServices;
...
loanProductReadBasicDetailsServices.foreach( service -> products.addAll(service.retrieveProducts());
We dont need to put anything into fineract-provider module.
adamsaghy
requested changes
Mar 2, 2026
Contributor
adamsaghy
left a comment
There was a problem hiding this comment.
Please see my concerns!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to have a Loan account application considering the Loan and Working Capital products supported now, we are adding a Loan product basic details endpoint to fetch those available products to be listed
FINERACT-2421
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.