FINERACT-2461: Refactor EmailReadPlatformServiceImpl to use Prepared Statements #5417
+57
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aman-Mittal
reviewed
Jan 30, 2026
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file |
Contributor
|
These changes really improved the code, but in my opinion it would be much more beneficial to rewrite it from jdbcTemplate to Spring Data JPA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored
EmailReadPlatformServiceImpl.javato replace legacy SQL string concatenation with JDBC Prepared Statements.This change prevents potential SQL injection vulnerabilities by using
?placeholders and passing parameters dynamically viaJdbcTemplate.Resolves FINERACT-2461.
Also related to FINERACT-2459.
Changes
retrieveAllPending,retrieveAllSent, and other read methods to use?placeholders.List<Object>to pass parameters dynamically.Checklist