FINERACT-2432: Avoid NPE when loanScheduleType is null/invalid #5332
+19
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@adamsaghy I recreated the PR from a clean branch and the conflicts are gone now. Could you please take another look when you have a moment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix NPE/IllegalArgumentException in LoanProductDataValidator when loanScheduleType is null/blank/invalid.
Instead of calling LoanScheduleType.valueOf(...) directly, this adds a guard + safe parsing and then reuses the parsed enum for the remaining checks.
Tested: ./gradlew :fineract-provider:resolve (local)