Skip to content

branch-4.1: [fix](cloud) Avoid deleting nonexistent delete bitmap files #62967#63012

Merged
yiguolei merged 1 commit intobranch-4.1from
auto-pick-62967-branch-4.1
May 7, 2026
Merged

branch-4.1: [fix](cloud) Avoid deleting nonexistent delete bitmap files #62967#63012
yiguolei merged 1 commit intobranch-4.1from
auto-pick-62967-branch-4.1

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 6, 2026

Cherry-picked from #62967

When recycling rowset data, the recycler treated a missing versioned delete bitmap meta key as "not packed" and added the standalone delete bitmap object path to the delete_files request. This caused unnecessary delete object requests for `<rowset_id>_delete_bitmap.db` even when no delete bitmap storage metadata existed.

The fix makes delete bitmap storage handling explicit: missing meta, FDB storage, standalone file storage, and packed file storage are distinguished. The recycler now only deletes `<rowset_id>_delete_bitmap.db` when the metadata explicitly indicates a standalone delete bitmap file.
@github-actions github-actions Bot requested a review from yiguolei as a code owner May 6, 2026 07:50
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen
Copy link
Copy Markdown
Contributor

run buildall

1 similar comment
@yiguolei
Copy link
Copy Markdown
Contributor

yiguolei commented May 6, 2026

run buildall

@yiguolei
Copy link
Copy Markdown
Contributor

yiguolei commented May 7, 2026

skip buildall

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions Bot commented May 7, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions Bot commented May 7, 2026

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 67fa57d into branch-4.1 May 7, 2026
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants