[opt](config) add max_bucket_num_per_partition config to limit bucket number#61576
Merged
hello-stephen merged 4 commits intoapache:masterfrom Mar 25, 2026
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
gavinchou
changed the title
Contributor
Author
|
run buildall |
…t number Add a new FE config `max_bucket_num_per_partition` to limit the maximum number of buckets when creating a table or adding a partition. Changes: 1. Add `max_bucket_num_per_partition` config in Config.java, defaulting to `autobucket_max_buckets` (128) for consistency. 2. Add bucket number validation in DistributionDescriptor.validate() for CREATE TABLE scenario. 3. Add bucket number validation in InternalCatalog.addPartition() for ALTER TABLE ADD PARTITION scenario. 4. Add unit tests for the new validation logic. Behavior: - For user-specified buckets (CREATE TABLE / ALTER TABLE ADD PARTITION): if bucket number exceeds this limit, the operation will be rejected. - For auto-bucket feature (Dynamic Partition): bucket number is capped by autobucket_max_buckets automatically. - Set to 0 or negative value to disable this limit.
gavinchou
force-pushed
the
gavin-limit-max-num-bucket
branch
from
673630a to
aba8238
Compare
Contributor
Author
|
run compile |
Add DistributionDescriptorTest to test the bucket number limit functionality: - Test normal bucket number within limit - Test bucket number exceeds limit throws AnalysisException - Test disable limit by setting to 0 - Test auto bucket is not limited by this config - Test random distribution also respects limit - Test bucket number zero or negative validation
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 26974 ms |
TPC-DS: Total hot run time: 168322 ms |
Contributor
FE UT Coverage ReportIncrement line coverage |
Two existing tests use large bucket numbers (2400) which exceed the default max_bucket_num_per_partition limit. Disable the limit in these tests to avoid test failures: - DecommissionTest.testDecommissionBackend - PartitionExprUtilTest.testAutoBucketLargeDataCalculatesBuckets
Contributor
Author
|
Fixed unit tests in DecommissionTest and PartitionExprUtilTest to disable max_bucket_num_per_partition limit for tests that use large bucket numbers. The other failing tests (LoadManagerTest, TableQueryPlanActionTest, CountStarSmallestSlotTest) are pre-existing issues unrelated to this change. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 26709 ms |
TPC-DS: Total hot run time: 168017 ms |
…st configurations Configure max_bucket_num_per_partition in regression test configs for testing.
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 26540 ms |
TPC-DS: Total hot run time: 168930 ms |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
|
skip buildall |
hello-stephen
approved these changes
Mar 25, 2026
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add a new FE config
max_bucket_num_per_partitionto limit the maximum number of buckets when creating a table or adding a partition.Changes:
max_bucket_num_per_partitionconfig in Config.java, defaulting toautobucket_max_buckets(128) for consistency.DistributionDescriptor.validate()for CREATE TABLE scenario.InternalCatalog.addPartition()for ALTER TABLE ADD PARTITION scenario.Behavior:
autobucket_max_bucketsautomatically, no change.Error message example:
Test plan
DistributionDescriptorTest.java