[Bug](catalog) fix runtime filter partition pruning error with binary type #59564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 31832 ms |
TPC-DS: Total hot run time: 172938 ms |
ClickBench: Total hot run time: 27.09 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31389 ms |
TPC-DS: Total hot run time: 173256 ms |
ClickBench: Total hot run time: 27.42 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
zhangstar333
force-pushed
the
iceberg_partition_filter
branch
from
7223bb9 to
40f886f
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31904 ms |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31765 ms |
TPC-DS: Total hot run time: 173439 ms |
ClickBench: Total hot run time: 26.79 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31814 ms |
TPC-DS: Total hot run time: 172372 ms |
ClickBench: Total hot run time: 26.94 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
1 similar comment
Contributor
FE Regression Coverage ReportIncrement line coverage |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
| return null; | ||
| } | ||
| return value.toString(); | ||
| case BINARY: |
Contributor
There was a problem hiding this comment.
A corresponding case needs to be added for paimon.
Contributor
Author
There was a problem hiding this comment.
// binary type as partition key will cause issues in paimon, so skipping these tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #53399
Problem Summary:
the serializePartitionValue function will return String value.
But the binary type use String with utf8 will be cause data corrupted， and it is not same with origin data.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)