-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[refactor](field) Remove nearest type in field #59488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
1 similar comment
|
run buildall |
|
|
||
| void insert(const Field& x) override { | ||
| const auto& value = vectorized::get<const StringViewField&>(x); | ||
| const auto& value = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
insert 一个field 的时候,到底是获取cpptype 还是 column item type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cpptype
|
run buildall |
1 similar comment
|
run buildall |
|
run buildall |
6 similar comments
|
run buildall |
|
run buildall |
|
run buildall |
|
run buildall |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 31614 ms |
TPC-DS: Total hot run time: 171886 ms |
ClickBench: Total hot run time: 26.94 s |
|
run buildall |
TPC-H: Total hot run time: 32118 ms |
TPC-DS: Total hot run time: 172566 ms |
ClickBench: Total hot run time: 27.36 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
|
run buildall |
eldenmoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 31455 ms |
TPC-DS: Total hot run time: 172961 ms |
ClickBench: Total hot run time: 27.37 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)