[Fix-18131] Workflow instance stuck in RUNNING state forever when using CONTINUE failure strategy with a failed upstream task

[SbloodyS]

Was this PR generated or assisted by AI?

Yes. IT is generated by AI.

Purpose of the pull request

fix #18131

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

[ruanwenjun]

Maybe we only need to add a new judge at AbstractWorkflowStateAction
line 90, if all triggerCandidateTasks's predecessor are inactive, and readyToTriggerTasks is empty then call emitWorkflowFinishedEventIfApplicable

protected void triggerTasks(final IWorkflowExecutionRunnable workflowExecutionRunnable,
                                final List<ITaskExecutionRunnable> triggerCandidateTasks) {
        final IWorkflowExecutionGraph workflowExecutionGraph = workflowExecutionRunnable.getWorkflowExecutionGraph();
        final List<ITaskExecutionRunnable> readyToTriggerTasks = triggerCandidateTasks
                .stream()
                .filter(workflowExecutionGraph::isTriggerConditionMet)
                .sorted(Comparator.comparing(ITaskExecutionRunnable::getName))
                .collect(Collectors.toList());
        final boolean isAllCandidateTaskPredecessorFinished = triggerCandidateTasks.stream()
                .flatMap(t -> workflowExecutionGraph.getPredecessors(t.getName()).stream())
                .allMatch(workflowExecutionGraph::isTaskExecutionRunnableInActive);

        if (CollectionUtils.isEmpty(readyToTriggerTasks)) {
            if (isAllCandidateTaskPredecessorFinished) {
                emitWorkflowFinishedEventIfApplicable(workflowExecutionRunnable);
            }
            return;
        }

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

[ruanwenjun]

We may don't need to change this case?

[SbloodyS]

Yes. You are right. I reverted this.

[ruanwenjun]

We may don't need to change this?

[SbloodyS]

It will cause local execution exceptions...