[Fix-17979][dao] Fix INT/BIGINT mismatch of workflow_definition_code in t_ds_serial_command.#17983
Open
iampratap7997-dot wants to merge 2 commits intoapache:devfrom
Open
Conversation
iampratap7997-dot
requested review from
EricGao888,
SbloodyS and
ruanwenjun
as code owners
ruanwenjun
force-pushed
the
fix/workflow-definition-code-bigint
branch
from
7123dae to
5ac882a
Compare
ruanwenjun
requested changes
Feb 18, 2026
Member
ruanwenjun
left a comment
ruanwenjun
left a comment
There was a problem hiding this comment.
Need to make change at
dolphinscheduler_h2.sql
dolphinscheduler_mysql.sql
dolphinscheduler_postgresql.sql
and add ddl at
postgresql/dolphinscheduler_ddl.sql
5ac882a to
d7eece0
Compare
Contributor
Author
Addressed the requested changes in H2, MySQL, and PostgreSQL schemas and added the required PostgreSQL upgrade DDL. Thanks, |
iampratap7997-dot
changed the title
ruanwenjun
reviewed
Feb 19, 2026
| CREATE TABLE IF NOT EXISTS `t_ds_serial_command` ( | ||
| `id` int(11) NOT NULL AUTO_INCREMENT COMMENT 'primary key', | ||
| `workflow_definition_code` int(11) NOT NULL COMMENT 'workflow definition code', | ||
| `workflow_definition_code` bigint(20) NOT NULL COMMENT 'workflow definition code', |
Member
There was a problem hiding this comment.
Please don't change the 3.4.0 ddl, since this version has been released, we should alter the column at 3.4.1 ddl.
Contributor
Author
There was a problem hiding this comment.
Please don't change the 3.4.0 ddl, since this version has been released, we should alter the column at 3.4.1 ddl.
Reverted changes in 3.4.0 schema and moved the column modification to 3.4.1 upgrade DDL as suggested.
Please review again.
Thanks.
iampratap7997-dot
force-pushed
the
fix/workflow-definition-code-bigint
branch
from
d7eece0 to
9c4d7c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This PR fixes a data type mismatch between the MySQL schema and Java entity mapping for
t_ds_serial_command.The column
workflow_definition_codewas defined asINT(11)in the 3.4.0 MySQL schema, while the corresponding Java field usesLong. This may cause data truncation errors when values exceed the range ofINT.Brief change log
workflow_definition_codefromINT(11)toBIGINT(20)in3.4.0_schema/mysql3.4.1_schema/mysqlto modify the existing column toBIGINT(20)workflowInstanceIdJava type fromIntegertoLongto match existing DB definition (BIGINT(20))Verify this pull request
This change is covered by existing tests.
Additionally:
INT(11)definition forworkflow_definition_codePull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md