[Improvement-17045][UI] copied task joined with underscore#17046
Closed
ChaoquanTao wants to merge 2 commits intoapache:devfrom
Closed
[Improvement-17045][UI] copied task joined with underscore#17046ChaoquanTao wants to merge 2 commits intoapache:devfrom
ChaoquanTao wants to merge 2 commits intoapache:devfrom
Conversation
|
SbloodyS
changed the title
SbloodyS
reviewed
Mar 12, 2025
| const genNums = 1 | ||
| const type = props.cell?.data.taskType | ||
| const taskName = uuid(props.cell?.data.taskName + '_') | ||
| const taskName = uuid(props.cell?.data.taskName + '-') |
Member
There was a problem hiding this comment.
Modifying the global rule directly will cause other task types to be abnormal, so I think we should create a new rule for the k8s task type.
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #17045
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md