[Improvement-16947][UI] Task instance log details should always stay at the bottom#16947
[Improvement-16947][UI] Task instance log details should always stay at the bottom#16947imizao wants to merge 9 commits intoapache:devfrom
Conversation
imizao
changed the title
SbloodyS
left a comment
SbloodyS
left a comment
There was a problem hiding this comment.
Please follow the pull request notice first.
SbloodyS
left a comment
SbloodyS
left a comment
There was a problem hiding this comment.
I think this feature needs disscussion. No all users needs this when the log is very large and refresh very fast.
Well, should I use it like this? [Improvement-16947][UI] Task instance log details should always stay at the bottom |
Add a button that allows the user to manually control whether to scroll to the bottom, without forcing automatic scrolling. Would that work? |
imizao
changed the title
Like this. |
You can take a look at https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md |
I think it's a good idea. |
The code has been submitted |
SbloodyS
left a comment
SbloodyS
left a comment
There was a problem hiding this comment.
Generally LGTM. Just some NIT.
|
You didn't create a new improvement issue and link to this PR. @imizao |
Co-authored-by: xiangzihao <zihaoxiang@apache.org>
Co-authored-by: xiangzihao <zihaoxiang@apache.org>
Fixed the NITs, thanks for the suggestions! |
| const variables = reactive({ | ||
| isFullscreen: false | ||
| isFullscreen: false, | ||
| autoScrollToBottom: true // New state variable |
There was a problem hiding this comment.
If we set to autoScrollToBottom to true by default. We should increase batch query log line num to 100000. This can significantly reduce the number of requests and improve the user experience.
There was a problem hiding this comment.
Thanks for the suggestion! In normal cases, a limit of 1000 is sufficient for most scenarios. The GIF I provided was an exceptional example to demonstrate the auto-scroll-to-bottom functionality, but it doesn't reflect the typical usage. Therefore, I believe keeping the limit at 1000 is appropriate for now. If we encounter performance issues or higher demand in the future, we can revisit this setting.
There was a problem hiding this comment.
In the production environment, 1000 is not enough for automatic refresh. It will cause great performance pressure on both frontend and backend. And we should avoid repeated execution and set a delay for it.
|
|
The |
I found that the submitted code is incomplete，can the page refresh automatically when the mouse reaches the bottom so that I don't have to manually update it? |
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |
4 participants
Purpose of the pull request
Task instance log details should always stay at the bottom.
close #16975
Brief change log
The log details area for task instances should always remain scrolled to the bottom, allowing users to view the latest log output in real-time.
Final effect 1
Final effect 2
Verify this pull request
This pull request is code cleanup without any test coverage.
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md