build: Fix docs workflow dependency resolution failure #3275
+39
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs workflow was failing because: 1. Using `-pl spark -am` in Maven compile caused it to look for comet-common in remote repos instead of building it locally 2. Missing Java setup step while running Maven compile Changes: - Remove `-pl spark -am` flags from Maven compile command - Add setup-java step with Java 17 and Maven cache Co-Authored-By: Claude Opus 4.5 <[email protected]>
andygrove
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3275 +/- ##
============================================
+ Coverage 56.12% 60.13% +4.00%
- Complexity 976 1456 +480
============================================
Files 119 175 +56
Lines 11743 16085 +4342
Branches 2251 2665 +414
============================================
+ Hits 6591 9673 +3082
- Misses 4012 5066 +1054
- Partials 1140 1346 +206 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
I need to test this more |
Add generate-docs Maven profile that can be explicitly enabled to generate documentation content during the package phase. This replaces the previous approach of running separate compile and exec:java commands. Changes: - Add generate-docs profile to spark/pom.xml that runs GenerateDocs - Update dev/generate-release-docs.sh to use the profile - Update docs/build.sh to use the profile with custom temp path The profile approach: - Avoids dependency resolution issues by running in the package phase - Only generates docs when explicitly requested with -Pgenerate-docs - Does not run during normal builds by default - Works for both release docs and docs website builds Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Member
Author
I reverted to using maven and added a specific profile for generating docs. This is ready for review now. |
mbutrovich
approved these changes
Jan 26, 2026
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
Thanks for sticking with this, @andygrove!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
-pl spark -amflags from Maven compile indocs/build.sh- this was causing Maven to look forcomet-commonin remote repos instead of building it locallysetup-javastep to the docs workflow since it runs Maven compileFixes https://github.com/apache/datafusion-comet/actions/runs/21340755149/job/61419724609
Test plan
🤖 Generated with Claude Code