Allow custom region from config #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds support for a configurable region parameter in the CloudStack cloud provider configuration, allowing users to specify a region independently of the zone. This addresses the limitation where the region was previously always set to the same value as the zone.
Key Changes:
- Added
regionfield to bothCSConfigandCSCloudstructs for configuration and storage - Updated
GetZonemethod to use the configured region when available, falling back to zone name when not set - Maintained backward compatibility by defaulting to zone name when region is not configured
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vishesh92
force-pushed
the
allow-custom-region
branch
2 times, most recently
from
ff4527c to
2433dd9
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vishesh92
force-pushed
the
allow-custom-region
branch
from
2433dd9 to
1f2ed33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39
Details
This pull request introduces support for a configurable
regionparameter in the CloudStack cloud provider code. The main change is the addition of theregionfield to the configuration and internal structures, allowing the region to be set independently of the zone. The logic in theGetZonemethod is updated to use the configured region if provided.Configuration and struct updates:
regionfield to theCSConfigstruct and its configuration parsing, allowing users to specify a region in their configuration file.regionfield to theCSCloudstruct to store the configured region for use throughout the codebase.newCSCloudconstructor to initialize theregionfield from the configuration.Behavioral change:
GetZonemethod to set thezone.Regionfield to the configured region if it is set; otherwise, it defaults to using the zone as the region.