Fix nodetool assassinate blocking the GOSSIP stage, causing the execu…#4713
Open
Runtian wants to merge 1 commit intoapache:cassandra-4.1from
Open
Fix nodetool assassinate blocking the GOSSIP stage, causing the execu…#4713Runtian wants to merge 1 commit intoapache:cassandra-4.1from
Runtian wants to merge 1 commit intoapache:cassandra-4.1from
Conversation
…ting node to be marked down and the liveness check to be ineffective
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ting node to be marked down and the liveness check to be ineffective
assassinateEndpoint (since CASSANDRA-15059) ran entirely inside runInGossipStageBlocking, including a 30-second RING_DELAY sleep. This blocked the single-threaded GOSSIP stage, causing two issues:
Fix: Move the heartbeat snapshot and sleep onto the caller (JMX) thread, keeping the GOSSIP stage free. Only enter the GOSSIP stage briefly to verify the heartbeat and perform the assassination. The
post-assassination propagation wait is also moved to the caller thread.