test: add comprehensive E2E tests for Secrets resource#3245
Merged
Baoyuantop merged 9 commits intoapache:masterfrom Dec 16, 2025
Merged
test: add comprehensive E2E tests for Secrets resource#3245Baoyuantop merged 9 commits intoapache:masterfrom
Baoyuantop merged 9 commits intoapache:masterfrom
Conversation
- Add POM (Page Object Model) for secrets in e2e/pom/secrets.ts - Add list page tests (navigation, pagination) in secrets.list.spec.ts - Add CRUD tests with required fields (Vault) in secrets.crud-required-fields.spec.ts - Add CRUD tests with all fields (AWS) in secrets.crud-all-fields.spec.ts - All tests use API-based operations for create/update/delete - Tests validate all three secret managers: vault, aws, gcp - 11 total tests covering list, create, read, update, delete operations Resolves apache#3091
Baoyuantop
reviewed
Nov 17, 2025
Contributor
Baoyuantop
left a comment
Baoyuantop
left a comment
There was a problem hiding this comment.
We can only use the API during initial resource preparation and final resource cleanup; all other operations should be performed through the UI.
- Update secrets via UI (Edit button -> modify fields -> Save) - Delete secrets via UI (Delete button -> confirm dialog) - Add UI verification to read/view tests - API now only used for initial setup verification and cleanup - All 8 tests passing Addresses feedback to use UI for all operations except setup/cleanup
Contributor
Author
|
API is now only used for initial setup verification and cleanup. All 8 tests passing. Addressed in e311c58 |
Baoyuantop
reviewed
Nov 17, 2025
- Replace API creation with UI form filling for secrets.crud-required-fields.spec.ts - Use proper form selectors and navigation expectations - Maintain test structure while following UI-first testing pattern - Satisfies review feedback to avoid API calls in main test flows
Contributor
Author
|
Fixed e2e secrets test failure by updating assertion to check input field value directly. |
SkyeYoung
approved these changes
Nov 21, 2025
SkyeYoung
requested changes
Nov 21, 2025
- Replaced API calls with UI interactions for creating secrets - Aligned with best practices for frontend E2E testing - Verified creation flows for AWS (all fields) and Vault (required fields)
SkyeYoung
requested changes
Nov 26, 2025
…date tests with object iteration.
… apisix_conf.yml comments and formatting.
Baoyuantop
approved these changes
Dec 16, 2025
SkyeYoung
approved these changes
Dec 16, 2025
archuser-q
pushed a commit
to archuser-q/security-gateway
that referenced
this pull request
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why submit this pull request?
What changes will this PR take into?
This PR adds comprehensive E2E tests for the Secrets resource, covering all CRUD operations and list page functionality.
Test Coverage (11 tests, all passing ✅):
List page tests (
secrets.list.spec.ts) - 3 testsCRUD with required fields (
secrets.crud-required-fields.spec.ts) - 4 testsCRUD with all fields (
secrets.crud-all-fields.spec.ts) - 4 testsFiles Added:
e2e/pom/secrets.ts- Page Object Model with navigation helpers and assertionse2e/tests/secrets.list.spec.ts- List page and pagination testse2e/tests/secrets.crud-required-fields.spec.ts- Vault manager CRUD testse2e/tests/secrets.crud-all-fields.spec.ts- AWS manager CRUD testsImplementation Details:
manager/id)Related issues
resolve #3091
Checklist: