Merged
Conversation
* Update golangci-lint to the latest availble version (v2.10.1) * Build and push a new codegen image with tag kubernetes-1.35.0-build.0 Some "false positives" needed to be handled after the golangci-lint update. No changes to the Go source code. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Go toolchain from version 1.25 to 1.26 and updates the golangci-lint version from v2.5.0 to v2.10.1. The upgrade requires building a new codegen Docker image with updated Go version and handling several gosec linter warnings that surfaced with the newer linter version.
Changes:
- Upgraded Go version from 1.25 to 1.26 in go.mod and build dependencies
- Updated golangci-lint from v2.5.0 to v2.10.1 with configuration changes to suppress G117 false positives
- Built and tagged new codegen image as kubernetes-1.35.0-build.0 with updated Go version
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updated Go version directive from 1.25.0 to 1.26.0 |
| build/images/deps/go-version | Updated Go version from 1.25 to 1.26 for Docker builds |
| Makefile | Updated golangci-lint version from v2.5.0 to v2.10.1 |
| .golangci.yml | Added exclusion rule for G117 gosec warnings (serialization of secrets - known false positives) |
| hack/update-codegen.sh | Updated codegen Docker image tag to kubernetes-1.35.0-build.0 |
| multicluster/hack/update-codegen.sh | Updated codegen Docker image tag to kubernetes-1.35.0-build.0 |
| build/images/codegen/README.md | Documented the new codegen image tag with Go v1.26 upgrade note |
| test/e2e/prometheus_test.go | Added #nosec G704 comment to suppress false positive for unhandled error audit |
| pkg/log/log_file.go | Added #nosec G703 comment explaining admin-provided path with no privilege boundary |
| pkg/flowaggregator/clickhouseclient/clickhouseclient_test.go | Added #nosec G101 comment for test credentials |
| pkg/controller/supportbundlecollection/validate_test.go | Added #nosec G101 comment for test credentials |
| pkg/controller/supportbundlecollection/controller_test.go | Added #nosec G101 comment for test credentials |
| pkg/apiserver/registry/controlplane/supportbundlecollection/rest_test.go | Added #nosec G101 comments for test credentials (3 instances) |
| pkg/antctl/runtime/runtime.go | Added #nosec G703 comment explaining user-provided path with no privilege boundary |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
petertran-avgo
approved these changes
Feb 23, 2026
luolanzone
approved these changes
Feb 25, 2026
Contributor
Author
|
/test-all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some "false positives" needed to be handled after the golangci-lint update.
No changes to the Go source code.