Fix integer overflow in OpenFlow meter stats#7786
Open
Av1ralS1ngh wants to merge 1 commit intoantrea-io:mainfrom
Open
Fix integer overflow in OpenFlow meter stats#7786Av1ralS1ngh wants to merge 1 commit intoantrea-io:mainfrom
Av1ralS1ngh wants to merge 1 commit intoantrea-io:mainfrom
Conversation
Use uint64 for packet counts in GetMeterStats to prevent overflow. Update interfaces, implementation, and tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetMeterStatsretrieves per-meter packet drop counts from OVS via OpenFlow multipart replies. The OVSPacketBandCountfield isuint64, but the callback signature truncated it toint64, causing silent overflow when cumulative drop counts exceedmath.MaxInt64.This change updates the entire call chain to use
uint64:What changed:
pkg/ovs/openflow/interfaces.go: updatedGetMeterStatscallback signature fromfunc(int, int64)tofunc(int, uint64).pkg/ovs/openflow/ofctrl_bridge.go: removed explicitint64cast;stats.BandStats[0].PacketBandCountis passed directly asuint64.pkg/agent/openflow/client.go: updatedhandleMeterStatsReplyto acceptuint64.pkg/agent/openflow/pipeline.go: changedovsMeterPacketDropsfrommap[int]*atomic.Int64tomap[int]*atomic.Uint64.pkg/ovs/openflow/ofctrl_bridge_test.go: aligned test assertions withuint64types.pkg/ovs/openflow/testing/mock_openflow.go: regenerated mock to match updated interface.pkg/agent/openflow/meter_test.go[NEW]: test covering initial counts, incremental updates, and values exceedingMaxInt64.Fixes Integer overflow in OpenFlow meter stats handling #7784