fix: allow Child() to accept relative 'kind/id' path (backwards compatible)#208
Open
ignoxx wants to merge 3 commits intoanthdm:masterfrom
Open
fix: allow Child() to accept relative 'kind/id' path (backwards compatible)#208ignoxx wants to merge 3 commits intoanthdm:masterfrom
ignoxx wants to merge 3 commits intoanthdm:masterfrom
Conversation
Previously, ctx.Child() required the full PID.ID to find a child,
which was counter-intuitive.
This change allows ctx.Child('kind/id') to work as expected while
maintaining backward compatibility with full PID.ID lookups.
Author
|
@tralafiti @anthdm would be nice to have this merged :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently,
ctx.Child()requires the fullPID.ID(e.g.,"parent/1/worker/123") to find a child actor. This is counter-intuitive because:SpawnChild(producer, "worker", WithID("123"))accepts kind and id separatelyctx.Child("worker/123")to work when called from the parent actorRelated issue: #168
Solution
This PR modifies
Child()to first try an exact match (for backward compatibility), then try prepending the parent's PID.ID to support the intuitive"kind/id"format.Usage