feat: Add wbtrace option for logger - embedding#1569
Open
dipinknair wants to merge 9 commits intomainfrom
Open
feat: Add wbtrace option for logger - embedding#1569dipinknair wants to merge 9 commits intomainfrom
dipinknair wants to merge 9 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1569 +/- ##
==========================================
- Coverage 80.31% 80.28% -0.04%
==========================================
Files 42 42
Lines 3196 3206 +10
==========================================
+ Hits 2567 2574 +7
- Misses 629 632 +3 🚀 New features to boost your workflow:
|
|
The documentation for this pull request will be available at https://mechanical.docs.pyansys.com/pull/1569. Please allow some time for the documentation to be deployed. |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Documentation | 2 minor |
🟢 Metrics 0 complexity
Metric Results Complexity 0
TIP This summary will be updated as you push new changes. Give us feedback
klmcadams
approved these changes
Apr 8, 2026
Collaborator
|
The changes are fine but I don't think it really closes #355 . For WBTRACING to be fully covered it should write to the same location as the logs (file, stdout, etc). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLoses #355