ci: run smoke tests with and without optional target#2714
Merged
Conversation
Up to standards ✅🟢 Issues
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2714 +/- ##
=======================================
Coverage 93.16% 93.16%
=======================================
Files 175 175
Lines 15075 15075
=======================================
Hits 14044 14044
Misses 1031 1031 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobPasMue
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enforces that the
ansys/actions/build-wheelhousenot only runs with thealltarget but also without any optional dependencies. While this will populate the release artifacts (filtering feature under development in ansys/actions#1260), it will ensure that the smoke test really does what we expect it to do.In a recent release of
pyaedt, we were impacted by such an issue due to some type hints improvement and refactoring. When running withalltarget nothing was wrong but installingpyaedtand then runningimport ansys.aedt.coreled us to an import error associated to a graphic dependency.Issue linked
None
Checklist
feat: extrude circle to cylinder)