Skip to content

ci: run smoke tests with and without optional target#2714

Merged
RobPasMue merged 3 commits intomainfrom
ci/ensure-success-import-without-target
Apr 17, 2026
Merged

ci: run smoke tests with and without optional target#2714
RobPasMue merged 3 commits intomainfrom
ci/ensure-success-import-without-target

Conversation

@SMoraisAnsys
Copy link
Copy Markdown
Contributor

Description

This PR enforces that the ansys/actions/build-wheelhouse not only runs with the all target but also without any optional dependencies. While this will populate the release artifacts (filtering feature under development in ansys/actions#1260), it will ensure that the smoke test really does what we expect it to do.

In a recent release of pyaedt, we were impacted by such an issue due to some type hints improvement and refactoring. When running with all target nothing was wrong but installing pyaedt and then running import ansys.aedt.core led us to an import error associated to a graphic dependency.

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner April 14, 2026 14:36
@github-actions github-actions bot added the maintenance Package and maintenance related label Apr 14, 2026
@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 14, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.16%. Comparing base (b7bd2fc) to head (0b57f35).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2714   +/-   ##
=======================================
  Coverage   93.16%   93.16%           
=======================================
  Files         175      175           
  Lines       15075    15075           
=======================================
  Hits        14044    14044           
  Misses       1031     1031           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue merged commit 9dc1eef into main Apr 17, 2026
69 checks passed
@RobPasMue RobPasMue deleted the ci/ensure-success-import-without-target branch April 17, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants