Make EDA CR file configurable via environment variable#293
Open
rooftopcellist wants to merge 2 commits intoansible:mainfrom
Open
Make EDA CR file configurable via environment variable#293rooftopcellist wants to merge 2 commits intoansible:mainfrom
rooftopcellist wants to merge 2 commits intoansible:mainfrom
Conversation
- Add EDA_CR env var to up.sh to specify custom CR file - Defaults to dev/eda-cr/eda-openshift-cr.yml - Replace hardcoded CR selection with configurable approach - Add feedback showing which CR file is being applied - Display available CR files for user reference - Update usage examples in both scripts
rooftopcellist
force-pushed
the
configurable-eda-cr-up-script
branch
from
07a07e0 to
5657a56
Compare
|
Alex-Izquierdo
approved these changes
Jul 11, 2025
Contributor
There was a problem hiding this comment.
This already contains the commit from #292
Except for that, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ability to configure which EDA Custom Resource (CR) file to apply during deployment via the EDA_CR environment variable, replacing the previous approach of manually un-commenting different CR files in the script.
Changes
EDA_CRenvironment variable with default valuedev/eda-cr/eda-openshift-cr.ymlUsage Examples
Default behavior (unchanged):
Using a custom CR file: