fix(opencode): preserve model favorites on startup #8356
Closed
+52
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8375
Summary
model.jsonwrites until model state is ready to avoid overwriting saved favoritesRoot Cause
Race condition in
local.tsx:save()can run beforemodel.jsonis loaded, writing empty favorites to disk.Changes
pendingSaveflag to queue writes until readyisModelEntry,normalizeModelList,normalizeVarianthelpers for defensive parsing