Skip to content

Conversation

@eXamadeus
Copy link

@eXamadeus eXamadeus commented Jan 14, 2026

What does this PR do?

Fixes: #8327

Related: #8269, #8380

Note

This is complementary to the v2 SDK upgrade in #8380. This PR improves type safety of the ToolContext used for developing custom tools in plugins. The other PR is focused on upgrading the client capabilities for plugins. Similar, but slightly different goals.

This PR aligns plugin tool types with the capabilities tools already have. Specifically:

  • Exposes ToolContext fields to plugin tools: callID, extra, metadata(), and ask() to give plugins the correct context types
  • Adds ExecuteResult type allowing plugin tools to return structured result objects with title, metadata, output, and attachments instead of only plain strings
  • Updates the registry to handle structured results from plugin tools, bypassing truncation when plugins return an ExecuteResult directly (assuming tools till truncate...we could add a check here?)
  • Exports all useful intermediate-types so plugin authors can use them more ergonomically.

This enables plugins to provide richer tool responses with proper metadata updates, closer matching the flexibility of built-in tools.

How did you verify your code works?

  • Ran the test suite
  • Ran TypeScript type checking
  • Verified locally with a plugin in development that required proper metadata updates from plugin tools

The types all align nicely in the registry:

Zight Recording 2026-01-13 at 09 43 34 PM

Fix plugin tool types to expose ToolContext fields and ExecuteResult
that built-in tools already have access to. The only functional change
is allowing plugin tools to return structured result objects (with title,
metadata, attachments) instead of only plain strings.
@github-actions
Copy link
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on my search, I found one potentially related PR:

Related PR:

This is related but not a duplicate since it's focused on a specific field addition rather than the broader alignment of plugin tool types with built-in capabilities that PR #8328 addresses.

No other duplicate PRs found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Plugin package tool types should stay aligned

1 participant