Merged
Conversation
rpereira-dev
added
bug
Update excit to remove issues with hardcoded -Werror, test the code against NVHPC SDK 24.7, and fix a couple of bugs in the process. Note: src/features.c depends on CUDA when CUDA is active, so might as well include the CUDA flags in the entire library. Note: The hwloc tests are written to test hwloc or the platform, instead of testing that aml is doing the right thing. We will need to change them drastically.
Fixed the buddy allocator
rpereira-dev
force-pushed
the
rpereira/allocator-chunk
branch
from
9a0c7b9 to
d40214e
Compare
perarnau
requested changes
Mar 10, 2025
Contributor
perarnau
left a comment
perarnau
left a comment
There was a problem hiding this comment.
Overall LGTM. Minor edits needed. And a rebase on master, now that the CI is working again.
I note that you don't NULL the new operators in the rest of the implementations. It's not strictly necessary but would be appreciated.
added 3 commits
March 12, 2025 13:45
set null explicitely to global variables ops returning AML_ENOTSUP on optional methods not implemented in allocators + added an assert for existance of mandatory methods
perarnau
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two optional interfaces to allocate/deallocate allocator's chunk directly, saving the cost of a hashmap - only implemented in the buddy allocator
Fixed issues in the buddy allocator that ultimately caused non-power of two allocations to return too small allocation.