[BrushGraph 6/7] Add Graph Canvas and core UI#65
Open
maxmmitchell wants to merge 2 commits intobrush-graph/5-complex-fieldsfrom
Open
[BrushGraph 6/7] Add Graph Canvas and core UI#65maxmmitchell wants to merge 2 commits intobrush-graph/5-complex-fieldsfrom
maxmmitchell wants to merge 2 commits intobrush-graph/5-complex-fieldsfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a node-based graph editor for brush configuration, including a zoomable canvas, automatic layout logic, and inspectors for nodes and edges. It also provides preview components and a test drawing surface. The review feedback recommends replacing magic strings and numbers with constants, removing an unused import, and addressing potential stack overflow risks in recursive layout functions.
maxmmitchell
force-pushed
the
brush-graph/6-canvas
branch
from
bcf7952 to
53d3ee1
Compare
maxmmitchell
force-pushed
the
brush-graph/5-complex-fields
branch
2 times, most recently
from
d78bbc2 to
7d9bfce
Compare
maxmmitchell
force-pushed
the
brush-graph/6-canvas
branch
from
53d3ee1 to
5bc8df0
Compare
maxmmitchell
force-pushed
the
brush-graph/6-canvas
branch
from
5bc8df0 to
261113b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the sixth PR in the Brush Graph stack. It introduces the actual canvas where nodes are drawn, connected, and panned/zoomed.
Details
GraphCameraController.Dependencies
brush-graph/5-complex-fields