VCU118 - Corundum: Updated scripts to solve critical warning related to system_top#1987
VCU118 - Corundum: Updated scripts to solve critical warning related to system_top#1987IstvanZsSzekely wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
caosjr
left a comment
There was a problem hiding this comment.
I have compiled the ad9081_fmca_ebz/vcu118 and ad4630 projects to check if the changes on the adi_project_xilinx.tcl affected other projects, they all seem fine. But in both main and in this branch I did not notice critical warning on Vivado 2025.1 version. Which version were you using?
I used the same version, Vivado 2025.1. |
|
RetriggerCI |
LBFFilho
left a comment
There was a problem hiding this comment.
Looks good, fixes the issue here on my builds. Just don't forget to update the headers for 2026
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
PR Description
All projects are expected to have the same system top module named
system_top.Current Corundum network stack uses an alternative system top module name, which has a different name from system_top. Because of this, Vivado reports a critical warning.
The changes in this scripts don't affect existing projects, it adds an optional parameter to
adi_project_files, which allows us to change the system_top module if needed.PR Type
PR Checklist