Skip to content

VCU118 - Corundum: Updated scripts to solve critical warning related to system_top#1987

Open
IstvanZsSzekely wants to merge 2 commits intomainfrom
ad9028_vcu118_corundum_update
Open

VCU118 - Corundum: Updated scripts to solve critical warning related to system_top#1987
IstvanZsSzekely wants to merge 2 commits intomainfrom
ad9028_vcu118_corundum_update

Conversation

@IstvanZsSzekely
Copy link
Contributor

@IstvanZsSzekely IstvanZsSzekely commented Jan 9, 2026

PR Description

All projects are expected to have the same system top module named system_top.
Current Corundum network stack uses an alternative system top module name, which has a different name from system_top. Because of this, Vivado reports a critical warning.
The changes in this scripts don't affect existing projects, it adds an optional parameter to adi_project_files, which allows us to change the system_top module if needed.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)
  • Documentation

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

Copy link
Contributor

@caosjr caosjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have compiled the ad9081_fmca_ebz/vcu118 and ad4630 projects to check if the changes on the adi_project_xilinx.tcl affected other projects, they all seem fine. But in both main and in this branch I did not notice critical warning on Vivado 2025.1 version. Which version were you using?

@IstvanZsSzekely
Copy link
Contributor Author

I have compiled the ad9081_fmca_ebz/vcu118 and ad4630 projects to check if the changes on the adi_project_xilinx.tcl affected other projects, they all seem fine. But in both main and in this branch I did not notice critical warning on Vivado 2025.1 version. Which version were you using?

I used the same version, Vivado 2025.1.
A note should be taken here that it wasn't tested on hardware just yet for this version, only on 2023.2.

@bia1708
Copy link
Collaborator

bia1708 commented Jan 20, 2026

RetriggerCI

LBFFilho
LBFFilho previously approved these changes Feb 24, 2026
Copy link
Contributor

@LBFFilho LBFFilho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, fixes the issue here on my builds. Just don't forget to update the headers for 2026

Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants