Skip to content

Update finances_2024-06-19.json: missing payload object#4772

Open
kevinvenclovas wants to merge 4 commits intoamzn:mainfrom
kevinvenclovas:main
Open

Update finances_2024-06-19.json: missing payload object#4772
kevinvenclovas wants to merge 4 commits intoamzn:mainfrom
kevinvenclovas:main

Conversation

@kevinvenclovas
Copy link
Copy Markdown

@kevinvenclovas kevinvenclovas commented May 4, 2025

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jevoniuk There are some big issues in the finances_2024-06-19.json. Please take a look :)

  • added payload object
  • added missing enum
  • fixed Breakdowns array type

Includes also:

@miridin
#4650
#4647

@shlomieconnect
Copy link
Copy Markdown

SETTLEMENT_ID needs to be in both the itemRelatedIdentifierName enum, and in the relatedIdentifierName enum (You already added it to the relatedIdentifierName enum, it needs to be in the itemRelatedIdentifierName as well)

I appreciate you taking time to update the models, while Amazon themselves doesn't really care if it's up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants