fix: add missing fields to protobuf agent conversions#4568
Merged
Conversation
APIKey, Prefix, and ExpiresAt were missing from the NotificationDispatcher protobuf message, causing these fields to be silently dropped when broadcasting notification config to agent nodes. Same class of bug as #4563. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
Looks good. Fix is correct —
No issues found. |
ActorAttributes was missing from the ContainerEvent proto message, causing container renames and event-based notification attributes (including exit codes) to be silently dropped on agent nodes. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
NetworkRxTotal and NetworkTxTotal were omitted in both ToProto() and FromProto() for container stats, causing network metrics to be lost when syncing container data via agents. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
Confirmed correct fix. The All three fixes are symmetric between |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
APIKey,Prefix, andExpiresAtmissing fromNotificationDispatcherprotobuf message — dispatchers with API key auth, prefixes, or expiration silently broken on agent nodesActorAttributesmissing fromContainerEventprotobuf message — container renames and event-based notification attributes (including exit codes) lost on agent nodesNetworkRxTotalandNetworkTxTotalmissing fromContainerStatinToProto()/FromProto()— network metrics lost when syncing container data via agentsSame class of bug as #4563 — fields present in Go structs but omitted during protobuf conversion.
Test plan
🤖 Generated with Claude Code