Skip to content

(ament_cpplint) Update cpplint version to v2.0.0#522

Closed
EricVoll wants to merge 1 commit intoament:rollingfrom
EricVoll:rolling
Closed

(ament_cpplint) Update cpplint version to v2.0.0#522
EricVoll wants to merge 1 commit intoament:rollingfrom
EricVoll:rolling

Conversation

@EricVoll
Copy link

PR #501 already contained an update to the latest cpplint version at the time. It was decided to split the changes there into two PRs. This PR updates the cpplint version to v2.0.0, which is superseded by 5 PRs fixing various things.

I went with v2.0.0. to have an officially released version instead of some mid-release version.

Fixes #500

@EricVoll EricVoll changed the title Update cpplint version to v2.0.0 (ament_cpplint) Update cpplint version to v2.0.0 Feb 14, 2025
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Our policy is to use the version available from system packages on Ubuntu. This way the version is consistent across all target platforms. Ubuntu 24.04 Noble (the Ubuntu version targeted for Rolling and Jazzy) currently provides version 1.6.1, so we could bump to that: https://packages.ubuntu.com/noble/cpplint.

(The current version is 1.5.5 because that was the version provided by Ubuntu 22.04 Jammy, and it just hasn't been bumped yet: https://packages.ubuntu.com/jammy/cpplint)

Also, please sign off your commit, see: https://docs.ros.org/en/rolling/The-ROS2-Project/Contributing/Developer-Guide.html#change-control-process.

@christophebedard
Copy link
Member

which is superseded by 5 PRs fixing various things.

I wonder if we should re-apply the changes that we made on top: https://github.com/ament/ament_lint/commits/185613c26a3f65cc802dc5bc05d42fd36381040f/ament_cpplint/ament_cpplint/cpplint.py

@christophebedard
Copy link
Member

Ubuntu 24.04 Noble (the Ubuntu version targeted for Rolling and Jazzy) currently provides version 1.6.1, so we could bump to that: https://packages.ubuntu.com/noble/cpplint.

#562 does this, and there's been no response on this PR for some time, so I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ament_cpplint Support for C++20

2 participants