Skip to content

feature: mixed sorting envoyfilter#3391

Open
Aias00 wants to merge 4 commits intoalibaba:mainfrom
Aias00:feature/mixed-sorting-envoyfilter-wasmplugin
Open

feature: mixed sorting envoyfilter#3391
Aias00 wants to merge 4 commits intoalibaba:mainfrom
Aias00:feature/mixed-sorting-envoyfilter-wasmplugin

Conversation

@Aias00
Copy link
Contributor

@Aias00 Aias00 commented Jan 26, 2026

Ⅰ. Describe what this PR did

support mixed sorting envoyfilter

link: #3371
link: higress-group/api#5
link: higress-group/istio#48

Ⅱ. Does this pull request fix one issue?

fixes: #3371

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Ⅵ. AI Coding Tool Usage Checklist (if applicable)

Please check all applicable items:

  • For new standalone features (e.g., new wasm plugin or golang-filter plugin):

    • I have created a design/ directory in the plugin folder
    • I have added the design document to the design/ directory
    • I have included the AI Coding summary below
  • For regular updates/changes (not new plugins):

    • I have provided the prompts/instructions I gave to the AI Coding tool below
    • I have included the AI Coding summary below

AI Coding Prompts (for regular updates)

AI Coding Summary

Copilot AI review requested due to automatic review settings February 7, 2026 15:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds EnvoyFilter CRD schema fields intended to support mixed ordering with WasmPlugins (issue #3371), by extending the installer-provided CRDs.

Changes:

  • Extend the EnvoyFilter CRD schema with wasmPhase (enum) and wasmPriority (int32) fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +3212 to +3225
wasmPhase:
description: Determines where in the filter chain this EnvoyFilter should
be injected for mixed sorting with WasmPlugins.
enum:
- UNSPECIFIED_PHASE
- AUTHN
- AUTHZ
- STATS
type: string
wasmPriority:
description: Determines ordering of EnvoyFilter in the same wasmPhase
for mixed sorting with WasmPlugins.
format: int32
type: integer
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description/linked issue describe implementing mixed sorting behavior between EnvoyFilter and WasmPlugin, but in this repo the only change appears to be adding wasmPhase/wasmPriority to the CRD schema. A repo-wide search shows no Go/proto code referencing these fields, so they will currently be inert (accepted by the API server but ignored by the control-plane logic). If this repo is expected to provide the mixed-sorting behavior, please include the corresponding API/type + sorting logic changes here; otherwise, clarify in the PR description that this is only the CRD/installer piece and ensure version compatibility with the control-plane that actually consumes the fields.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Mixed Sorting Between EnvoyFilter and WasmPlugin

1 participant