Conversation
There was a problem hiding this comment.
Pull request overview
Adds EnvoyFilter CRD schema fields intended to support mixed ordering with WasmPlugins (issue #3371), by extending the installer-provided CRDs.
Changes:
- Extend the EnvoyFilter CRD schema with
wasmPhase(enum) andwasmPriority(int32) fields.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| wasmPhase: | ||
| description: Determines where in the filter chain this EnvoyFilter should | ||
| be injected for mixed sorting with WasmPlugins. | ||
| enum: | ||
| - UNSPECIFIED_PHASE | ||
| - AUTHN | ||
| - AUTHZ | ||
| - STATS | ||
| type: string | ||
| wasmPriority: | ||
| description: Determines ordering of EnvoyFilter in the same wasmPhase | ||
| for mixed sorting with WasmPlugins. | ||
| format: int32 | ||
| type: integer |
There was a problem hiding this comment.
The PR description/linked issue describe implementing mixed sorting behavior between EnvoyFilter and WasmPlugin, but in this repo the only change appears to be adding wasmPhase/wasmPriority to the CRD schema. A repo-wide search shows no Go/proto code referencing these fields, so they will currently be inert (accepted by the API server but ignored by the control-plane logic). If this repo is expected to provide the mixed-sorting behavior, please include the corresponding API/type + sorting logic changes here; otherwise, clarify in the PR description that this is only the CRD/installer piece and ensure version compatibility with the control-plane that actually consumes the fields.
…mixed sorting with WasmPlugins
Ⅰ. Describe what this PR did
support mixed sorting envoyfilter
link: #3371
link: higress-group/api#5
link: higress-group/istio#48
Ⅱ. Does this pull request fix one issue?
fixes: #3371
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Ⅵ. AI Coding Tool Usage Checklist (if applicable)
Please check all applicable items:
For new standalone features (e.g., new wasm plugin or golang-filter plugin):
design/directory in the plugin folderdesign/directoryFor regular updates/changes (not new plugins):
AI Coding Prompts (for regular updates)
AI Coding Summary