refactor: delegate sandbox control logic to deployment #277 #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FangwenDave
force-pushed
the
feature/refactor_sandboxmanager
branch
4 times, most recently
from
f5d2972 to
ddca701
Compare
StephenRi
reviewed
Jan 23, 2026
StephenRi
reviewed
Jan 23, 2026
StephenRi
reviewed
Jan 23, 2026
StephenRi
reviewed
Jan 23, 2026
StephenRi
reviewed
Jan 23, 2026
StephenRi
reviewed
Jan 23, 2026
StephenRi
reviewed
Jan 23, 2026
FangwenDave
force-pushed
the
feature/refactor_sandboxmanager
branch
3 times, most recently
from
f892599 to
fd387e1
Compare
StephenRi
reviewed
Jan 26, 2026
StephenRi
reviewed
Jan 26, 2026
StephenRi
reviewed
Jan 26, 2026
FangwenDave
force-pushed
the
feature/refactor_sandboxmanager
branch
2 times, most recently
from
3ef521d to
4d87894
Compare
FangwenDave
force-pushed
the
feature/refactor_sandboxmanager
branch
from
4d87894 to
1485490
Compare
StephenRi
reviewed
Jan 27, 2026
StephenRi
reviewed
Jan 27, 2026
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue #277 by delegate sandbox controlling APIs (start_async, stop, and get_status) to the sandbox manager. This refactoring removes the unnecessary Ray dependency from the sandbox manager, improving modularity and reducing coupling.