Skip to content

Conversation

@sarahdayan
Copy link
Member

@sarahdayan sarahdayan commented Feb 3, 2026

Summary

Removes the mkdirp dependency by using Node.js native fs.mkdirSync with the recursive option.

Why

  • fs.mkdirSync(path, { recursive: true }) has been available since Node.js 10.12.0
  • Ship.js requires Node.js 20+, so this native API is guaranteed to be available
  • Reduces external dependencies

Changes

  • Replace mkdirpSync calls with fs.mkdirSync(path, { recursive: true }) in:
    • addCircleCIConfig.js
    • addGitHubActions.js
  • Remove mkdirp from dependencies

@sarahdayan sarahdayan requested review from a team, FabienMotte, dhayab and shaejaz and removed request for a team February 3, 2026 14:02
@sarahdayan sarahdayan force-pushed the chore/replace-parse-github-url branch from cb4410f to 30e6817 Compare February 3, 2026 15:00
@Haroenv Haroenv removed request for dhayab and shaejaz February 3, 2026 15:55
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually CI is failing, seems unrelated but not sure what exactly happens

@sarahdayan sarahdayan force-pushed the chore/replace-parse-github-url branch from 30e6817 to 5a03df5 Compare February 3, 2026 18:41
@sarahdayan
Copy link
Member Author

@Haroenv This was some conflict caused by the upstream Vitest migration. It's good now.

@sarahdayan sarahdayan requested a review from Haroenv February 3, 2026 19:22
@sarahdayan sarahdayan force-pushed the chore/replace-parse-github-url branch from 5a03df5 to 34ec6f5 Compare February 3, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants