Skip to content

refactor: replace parse-github-url with internal utility #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sarahdayan wants to merge 1 commit into
base: chore/replace-shelljs-with-execa
Choose a base branch
from
Open

refactor: replace parse-github-url with internal utility #1027

sarahdayan wants to merge 1 commit into from

Conversation

@sarahdayan
Copy link
Member

@sarahdayan sarahdayan commented Feb 3, 2026 •
edited
Loading

Summary

Replaces parse-github-url with a simple internal utility function.

Why

  • parse-github-url hasn't been updated since 2019
  • The functionality needed is simple enough to implement internally
  • Reduces external dependencies

Changes

  • Remove parse-github-url dependency from shipjs-lib
  • Add new parseGitHubURL.js utility that handles:
    • HTTPS URLs (https://github.com/owner/repo.git)
    • SSH URLs ([email protected]:owner/repo.git)
    • URLs without protocol (github.com/owner/repo)
    • URLs with branch paths (/tree/branch)
  • Update getRepoInfo.js, getRepoURLWithToken.js, getRepoURLWithTokenMasked.js to use new utility
  • Add unit tests for the new utility

@sarahdayan sarahdayan force-pushed the chore/replace-shelljs-with-execa branch from 77a39b8 to e01140b Compare February 3, 2026 13:46
@sarahdayan sarahdayan force-pushed the chore/replace-parse-github-url branch 2 times, most recently from 58be2f1 to cb4410f Compare February 3, 2026 13:53
@sarahdayan sarahdayan requested review from a team, Haroenv, aymeric-giraudet and dhayab and removed request for a team February 3, 2026 13:55
@sarahdayan sarahdayan force-pushed the chore/replace-shelljs-with-execa branch from 7d62c2a to bba910e Compare February 3, 2026 14:58
@sarahdayan sarahdayan force-pushed the chore/replace-parse-github-url branch 2 times, most recently from 30e6817 to 5a03df5 Compare February 3, 2026 18:41
@sarahdayan sarahdayan force-pushed the chore/replace-shelljs-with-execa branch 2 times, most recently from e1b1bd7 to ab25921 Compare February 3, 2026 19:18
@sarahdayan sarahdayan force-pushed the chore/replace-parse-github-url branch from 5a03df5 to 34ec6f5 Compare February 3, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Haroenv Haroenv Awaiting requested review from Haroenv Haroenv was automatically assigned from algolia/frontend-experiences-web

@aymeric-giraudet aymeric-giraudet Awaiting requested review from aymeric-giraudet aymeric-giraudet was automatically assigned from algolia/frontend-experiences-web

@dhayab dhayab Awaiting requested review from dhayab

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sarahdayan