chore: fix CommonJS remnants in ESM codebase #1020
Merged
+54
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahdayan
requested review from
a team,
FabienMotte and
aymeric-giraudet
and removed request for
a team
|
Should we add a |
Member
Author
|
@FabienMotte Done! Added The |
sarahdayan
force-pushed
the
chore/update-eslint
branch
from
a9240b0 to
5928c5a
Compare
sarahdayan
force-pushed
the
chore/fix-commonjs
branch
from
edd2c07 to
c670ac5
Compare
aymeric-giraudet
approved these changes
Feb 3, 2026
Update build tooling for shipjs-lib: - rollup: 2.14.0 → 4.34.8 - rollup-plugin-commonjs → @rollup/[email protected] - rollup-plugin-node-resolve → @rollup/[email protected] Updated rollup.config.js to use the new scoped plugin packages and createRequire for JSON imports (ESM compatible). Co-Authored-By: Claude Opus 4.5 <[email protected]>
Update linting tooling: ESLint: - eslint: 7.2.0 → 8.57.1 - eslint-config-algolia: 16.0.0 → 20.0.0 - eslint-config-prettier: 6.11.0 → 8.10.0 - eslint-plugin-import: 2.20.2 → 2.31.0 - eslint-plugin-jest: 23.13.2 → 27.9.0 - eslint-plugin-prettier: 3.1.3 → 4.2.1 - eslint-plugin-jsdoc: added 46.10.1 Parser: - babel-eslint → @babel/[email protected] Updated .eslintrc.cjs to use @babel/eslint-parser and disable removed/incompatible rules. Note: Prettier remains at 2.x due to ESM compatibility issues with Jest. Prettier 3.x upgrade can be done in a future PR. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Auto-fixed lint errors from ESLint 8 stricter rules: - import/order: Sorted imports by group (builtin, external, internal) - import/newline-after-import: Added newlines after imports - no-else-return: Removed unnecessary else after return - jest/prefer-to-be: Use toBe/toBeNull for primitive checks Also fixed a buggy mock in updateVersionMonorepo.spec.js that was attempting to spy on a non-existent property. Co-Authored-By: Claude Opus 4.5 <[email protected]>
sarahdayan
force-pushed
the
chore/update-eslint
branch
from
5928c5a to
46a1406
Compare
Update testing and transpilation tooling: Jest ecosystem: - jest: 26.0.1 → 29.7.0 - babel-jest: 26.0.1 → 29.7.0 - jest-watch-typeahead: 0.6.0 → 2.2.2 Babel ecosystem (required for Jest 29 compatibility): - @babel/core: 7.10.2 → 7.26.9 - @babel/preset-env: 7.10.2 → 7.26.9 - @babel/plugin-transform-runtime: 7.10.1 → 7.26.9 - @babel/runtime: ^7.6.3 → ^7.28.6 Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Convert require() to dynamic import() in updateChangelog.js - Replace .toString() with 'utf-8' encoding parameter in readFileSync calls - Fix 'require' to 'import' in updateChangelog.spec.js Co-Authored-By: Claude Opus 4.5 <[email protected]>
Exclude test directories from security-focused rules. Tests legitimately use dynamic paths (e.g., __dirname + path.resolve) to load fixtures, which triggers false positive "path injection" warnings. Co-Authored-By: Claude Opus 4.5 <[email protected]>
sarahdayan
force-pushed
the
chore/fix-commonjs
branch
from
c670ac5 to
c2deda9
Compare
sarahdayan
force-pushed
the
chore/fix-commonjs
branch
from
2a79787 to
4be773b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
require()to dynamicimport()inupdateChangelog.jsfor config loading.toString()with'utf-8'encoding parameter inreadFileSync()calls across the codebaserequire('path')toimport path from 'path'inupdateChangelog.spec.jsFiles changed
shipjs-lib:
src/lib/util/updateVersion.js- use'utf-8'encodingshipjs:
src/step/prepare/updateChangelog.js- convertrequire()to dynamicimport()src/step/prepare/__tests__/updateChangelog.spec.js- convertrequiretoimportsrc/helper/extractSpecificChangelog.spec.js- remove unusedimport.meta.urlimportsrc/helper/dependencyUpdater.js- use'utf-8'encodingsrc/helper/getChangelog.js- use'utf-8'encodingsrc/helper/runPrettier.js- use'utf-8'encodingsrc/step/setup/addDevDependencies.js- use'utf-8'encodingsrc/step/setup/addScriptsToPackageJson.js- use'utf-8'encodingsrc/step/setup/addShipConfig.js- use'utf-8'encodingsrc/step/setup/askQuestions.js- use'utf-8'encoding