feat(chat): handle setting refinements from the search index tool 'view all' button#6866
Open
feat(chat): handle setting refinements from the search index tool 'view all' button#6866
Conversation
shaejaz
changed the title
Haroenv
reviewed
Jan 23, 2026
packages/instantsearch.js/src/connectors/current-refinements/connectCurrentRefinements.ts
Outdated
Show resolved
Hide resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1caa6c9:
|
shaejaz
changed the title
Haroenv
reviewed
Jan 26, 2026
Contributor
Haroenv
left a comment
Haroenv
left a comment
There was a problem hiding this comment.
looks good, missing a couple edge cases I think, but on the right track
packages/instantsearch.js/src/lib/utils/updateStateFromSearchToolInput.ts
Outdated
Show resolved
Hide resolved
packages/instantsearch.js/src/lib/utils/updateStateFromSearchToolInput.ts
Outdated
Show resolved
Hide resolved
packages/instantsearch.js/src/lib/utils/updateStateFromSearchToolInput.ts
Outdated
Show resolved
Hide resolved
FabienMotte
reviewed
Jan 26, 2026
Contributor
FabienMotte
left a comment
FabienMotte
left a comment
There was a problem hiding this comment.
Nice! I left some minors questions/suggestions
packages/instantsearch.js/src/lib/utils/updateStateFromSearchToolInput.ts
Outdated
Show resolved
Hide resolved
packages/react-instantsearch/src/widgets/chat/tools/SearchIndexTool.tsx
Outdated
Show resolved
Hide resolved
packages/instantsearch.js/src/lib/utils/updateStateFromSearchToolInput.ts
Outdated
Show resolved
Hide resolved
FabienMotte
approved these changes
Feb 3, 2026
Contributor
Screen.Recording.2026-02-03.at.16.58.54.movlooks like we aren't clearing filters of other widgets. We should do a global clean of parameters (look how clearRefinements does it, or do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FX-3631
This PR adds setting refinements (not just query) from the 'View All' button in the default Search Index Tool component. A new param,
applyFiltersis now provided to thelayoutComponentof tools.