fix the problem of setImageURI behavior#189
Open
AbdallaBadreldin wants to merge 1 commit intoalexvasilkov:masterfrom
Open
fix the problem of setImageURI behavior#189AbdallaBadreldin wants to merge 1 commit intoalexvasilkov:masterfrom
AbdallaBadreldin wants to merge 1 commit intoalexvasilkov:masterfrom
Conversation
Hello the library is working well when we set setImageDrawable(Drawable) or just use src from xml the problem happen when we use setImageBitmap(Bitmap) || setImageURI(Uri) for newer SDKs I figured out that when developer call SetImageDrawable() the library start to updated Controller and dimention so but for other function the library doesn't update dimentions, invalidateDrawable(Drawable) is good for fixing this problem but it will create another issues, soI mdae function that is common it's in the same Class (GestureImageView) once developer call any function to show a picture this this function is going to be invoked thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
the library is working well when we set setImageDrawable(Drawable) or just use src in xml. The problem happens when we use
setImageBitmap(Bitmap) || setImageURI(Uri) for newer SDKs
I figured out that when developer call setImageDrawable() the library start to updated Controller and dimention but for other functions the library doesn't update dimentions, invalidateDrawable(Drawable) is good for fixing this problem but it will create another issues, so I made a function and moved the bulk of code that happen in setImageDrawable() in it. it's in the same class (GestureImageView) once the developer calls any function to show a picture. This function will be invoked
thank you