Skip to content

Remove metro keep rules#2785

Open
alexvanyo wants to merge 105 commits intomainfrom
av/remove-metro-keep-rules
Open

Remove metro keep rules#2785
alexvanyo wants to merge 105 commits intomainfrom
av/remove-metro-keep-rules

Conversation

@alexvanyo
Copy link
Owner

Fixes #2783

@alexvanyo alexvanyo enabled auto-merge (rebase) August 5, 2025 02:35
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @alexvanyo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've removed specific ProGuard keep rules related to MetroContribution from the app/staging-test-proguard-rules.pro file. This change addresses a previously identified issue (Fixes #2783) and likely contributes to a more optimized or stable build process by eliminating unnecessary or problematic ProGuard directives.

Highlights

  • ProGuard Configuration: Removed keep,allowoptimization class **.*$$$MetroContribution* rules from app/staging-test-proguard-rules.pro.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a ProGuard keep rule for the Metro library from the staging-test build configuration. This is a good cleanup. My review identified a potentially related -dontwarn rule that could also be removed to make the cleanup more complete.

@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.31%. Comparing base (7c4572d) to head (d5a95cc).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2785      +/-   ##
============================================
- Coverage     69.64%   68.31%   -1.33%     
============================================
  Files           280      280              
  Lines         13940    13940              
  Branches       2052     2052              
============================================
- Hits           9708     9523     -185     
- Misses         3220     3411     +191     
+ Partials       1012     1006       -6     
Flag Coverage Δ
23 68.26% <ø> (ø)
36 68.22% <ø> (ø)
aospatd-pixel6pro-35 ?
device ?
unit 68.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexvanyo
Copy link
Owner Author

Cannot auto-update because of conflicts.

@alexvanyo alexvanyo force-pushed the av/remove-metro-keep-rules branch from 17025fd to ec8c76f Compare December 14, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove keep rules for metro contributions

1 participant