Add support for selecting font families when creating a form PDF#312
Open
jdalrymple wants to merge 5 commits intoalam00000:mainfrom
Open
Add support for selecting font families when creating a form PDF#312jdalrymple wants to merge 5 commits intoalam00000:mainfrom
jdalrymple wants to merge 5 commits intoalam00000:mainfrom
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
(Still adding tests) |
jdalrymple
commented
Dec 27, 2025
.gitignore
Outdated
| lerna-debug.log* | ||
|
|
||
| node_modules | ||
| dist |
Author
There was a problem hiding this comment.
To avoid commiting the package output
jdalrymple
commented
Dec 27, 2025
| const STANDARD_FONT_NAMES: string[] = Object.values(StandardFonts) | ||
|
|
||
| // Additional fonts storage | ||
| let additionalFonts: string[] = [] |
Author
There was a problem hiding this comment.
There might be a better way to do this, im open to suggestions
jdalrymple
commented
Dec 27, 2025
| label.style.fontFamily = fontName.includes('Times') ? 'serif' : | ||
| fontName.includes('Courier') ? 'monospace' : 'sans-serif' | ||
|
|
||
| // Count how many fields use this font |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
I can try and resolve the new conflicts after this has been reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a user creates a PDF form, they can now select the font family used for the text fields.
New Form Properties area shows all embedded fonts
Font families drop down shows all standard fonts available, and defaults to Helvetica
Adding Custom Font modal
By Google font name

By font URL

By uploaded file

Updated font list after custom font addition
Updated live render / output font render in the pdf
Embedded font information
Fixes #261
Type of change
Please delete options that are not relevant.
🧪 How Has This Been Tested?
Please describe how you tested your changes so that maintainers can verify them. Include enough detail for someone else to reproduce your tests.
Checklist:
Expected Results:
Actual Results:
Checklist: