[CEQIF-640] Remove duplicate product delete filter#20571
Open
SorenHopkins wants to merge 2 commits into7.0from
Open
[CEQIF-640] Remove duplicate product delete filter#20571SorenHopkins wants to merge 2 commits into7.0from
SorenHopkins wants to merge 2 commits into7.0from
Conversation
mmetayer
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (for Contributor and Core Developer)
This PR removes a check in the yml file for the delete button in the product grid. This check only determines whether the delete button should be available for users who have the "delete products" permission, and does not not determine whether it should be available for those with the "delete product models" permission. Both are checked at determining the visibility of the button in the delete-product-action.js file at line 41, so this additional check is unnecessary, and prevents users with the "delete product models" permission from deleting product models in the product grid if they do not have the "delete products" permission.
Additional
Also upgrades the version of
aws/aws-sdk-phppackage (only used in dev requirements), because of https://www.cvedetails.com/cve/CVE-2023-51651/