Add missing clipboard write permission#2395
Open
ShreyMarwaha wants to merge 2 commits intoajayyy:masterfrom
Open
Add missing clipboard write permission#2395ShreyMarwaha wants to merge 2 commits intoajayyy:masterfrom
ShreyMarwaha wants to merge 2 commits intoajayyy:masterfrom
Conversation
Added 'clipboardWrite' to extension permissions in manifest.json and set 'allow' attribute to 'clipboard-write' on the info menu iframe in content.ts to enable clipboard operations.
ShreyMarwaha
changed the title
Owner
|
I don't think both are required. Just the iframe permission should work right? |
The clipboardWrite permission was removed from the manifest.json file, likely to reduce unnecessary permissions and improve security.
Author
|
@ajayyy Yes, you are correct. Since we are writing to the clipboard on user interaction, we do not need the permission in the manifest.json. I have removed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test this pull request, follow the instructions in the wiki.
This fixes: #2362
Added 'clipboardWrite' to extension permissions in manifest.json and set 'allow' attribute to 'clipboard-write' on the info menu iframe to enable clipboard operations.
Testing Results
Before:
After:
Copy button working as expected. No exception in console.