Updated max-width to fix overlap error#1895
Open
Choromanski wants to merge 1 commit intoajayyy:masterfrom
Open
Updated max-width to fix overlap error#1895Choromanski wants to merge 1 commit intoajayyy:masterfrom
Choromanski wants to merge 1 commit intoajayyy:masterfrom
Conversation
Owner
|
How does this look with the popup in the browser top right |
Contributor
Author
|
Before: 
After: 
I'll experiment with other solutions. |
Owner
|
Related #1429 |
Contributor
Author
|
Issue #1429 results in the text running off the side of the page and can probably be closed: |
Contributor
Author
|
The discrepancy between youtube popup and browser popup is caused by the scrollbar, how do you feel about potentially removing the scrollbar but keeping scrolling functionality? |
Owner
|
Hiding scrollbars is generally bad for accessibility, so I don't think it should be done. That may be why I never noticed it because I use Linux and have a very slim scrollbar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test this pull request, follow the instructions in the wiki.
Solution for #1821
Before:
After:
