Skip to content

Shorten generated Paparazzi filenames #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
allenchen1154 wants to merge 1 commit into from
Closed

Shorten generated Paparazzi filenames #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ava/com/airbnb/android/showkase/processor/writer/PaparazziShowkaseScreenshotTestWriter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class PaparazziShowkaseScreenshotTestWriter(private val environment: XProcessing
rootModulePackageName: String,
testClassName: String
) {
val showkaseScreenshotTestClassName = "${testClassName}_PaparazziShowkaseTest"
val showkaseScreenshotTestClassName = "${testClassName}Impl"
val fileBuilder = getFileBuilder(screenshotTestPackageName, showkaseScreenshotTestClassName)
fileBuilder
.addImport(rootModulePackageName, "getMetadata")
Expand Down
6 changes: 5 additions & 1 deletion ...m/airbnb/android/showkase/screenshot/testing/paparazzi/PaparazziShowkaseScreenshotTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,11 @@ interface PaparazziShowkaseScreenshotTest {
direction: LayoutDirection,
mode: PaparazziShowkaseUIMode
) {
paparazzi.snapshot(name = testPreview.toString()) {
paparazzi.snapshot(
// No need to pass name here as the Paparazzi instance already uses the
// containing test class name, test function, and function arguments to generate
// a unique screenshot file name.
) {
val lifecycleOwner = LocalLifecycleOwner.current
val configuration = if (mode == PaparazziShowkaseUIMode.DARK) {
Configuration(LocalConfiguration.current).apply {
Expand Down
Loading