Use build_key(key, namespace) consistently across modules and classes#570
Open
padraic-shafer wants to merge 4 commits intoaio-libs:masterfrom
Open
Use build_key(key, namespace) consistently across modules and classes#570padraic-shafer wants to merge 4 commits intoaio-libs:masterfrom
padraic-shafer wants to merge 4 commits intoaio-libs:masterfrom
Conversation
* See aio-libs#473: Deprecate using cache specific constructors * aio-libs#473 * `Cache` class was introduced as a proxy for instantiating the different backends. There should be only one way of doing things and `Cache` is the preferred way of doing that so will deprecate the others. * This is now applied to `cached._get_cache()`
* Include build_key(key, namespace) in decorators.cached:
* get_from_cache()
* set_in_cache()
* Use namespace, if available, to build key that is passed to plugins.HitMissRatioPlugin.post_get()
* `BaseCache.key_filter(key, namespace)` returns True if key is in the namespace * `backends.memory.SimpleMemoryBackend` uses this to seleectively clear its cache for the given namespace
Contributor
Author
|
Hi, do you have an feedback for this PR? |
Member
|
Thanks, but will need a test that shows the incorrect behaviour. Also, please update to latest master, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_key(key, namespace)is missing from some modules/classes #569 for more informationto plugins.HitMissRatioPlugin.post_get()
BaseCache.key_filter(key, namespace)returns Trueif key is in the namespace
backends.memory.SimpleMemoryBackenduses this to seleectivelyclear its cache for the given namespace
What do these changes do?
Keys with namespaces now work throughout the
aiocachepackageAre there changes in behavior for the user?
Keys with namespaces now work throughout the
aiocachepackage.This includes using:
@cached()decoratorHitMissRatioPluginpluginSimpleMemoryCache.clear()memberRelated issue number
#569:
build_key(key, namespace)is missing from some modules/classesChecklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.