reversed "update" method in multi_cache to overwrite old values with new#489
Open
Trizalio wants to merge 2 commits intoaio-libs:masterfrom
Open
reversed "update" method in multi_cache to overwrite old values with new#489Trizalio wants to merge 2 commits intoaio-libs:masterfrom
Trizalio wants to merge 2 commits intoaio-libs:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #489 +/- ##
=======================================
Coverage 99.13% 99.13%
=======================================
Files 13 13
Lines 1043 1044 +1
Branches 116 116
=======================================
+ Hits 1034 1035 +1
Misses 9 9
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Member
|
Looks reasonable, but as mentioned, please add a test (after merging master). Test probably should go in tests/ut/test_decorators.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If wrapped function can return dict with more keys, than required there is a case, in which new value will be replaced by old, example:
will be printed:
As we can see, on second call of
foovalue for1changed, but it was overwritten by cache value.In my case i must return aggregated values based on values from two distinct bigdata storages. Based on requested keys i can predict future requests, so i'd like to preload values for predicted keys with keys passed to my funstion and save them all in aiocache