Skip to content

Add support for rerank model capability#179

Merged
mikehostetler merged 6 commits intoagentjido:mainfrom
sezaru:main
Apr 19, 2026
Merged

Add support for rerank model capability#179
mikehostetler merged 6 commits intoagentjido:mainfrom
sezaru:main

Conversation

@sezaru
Copy link
Copy Markdown
Contributor

@sezaru sezaru commented Apr 18, 2026

Description

Brief description of changes.

Type of Change

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature causing existing functionality to change)
  • Documentation update

Testing

  • Tests pass (mix test)
  • Quality checks pass (mix quality)

Checklist

  • My code follows the project's style guidelines
  • I have updated the documentation accordingly
  • I have added tests that prove my fix/feature works # NOTE I didn't add tests since I didn't saw any tests for the other capabilities options in the code.
  • All new and existing tests pass
  • My commits follow conventional commit format
  • I have NOT edited CHANGELOG.md (it is auto-generated by git_ops)
  • I have NOT directly edited generated snapshot/history artifacts unless this PR intentionally regenerates them (priv/llm_db/snapshot.json, priv/llm_db/history/**) # NOTE I ran mix llm_db.build --install which updated the snapshot.json file

Related Issues

Closes agentjido/req_llm#620

@sezaru
Copy link
Copy Markdown
Contributor Author

sezaru commented Apr 18, 2026

Hmm, the ci unit tests failed, but I don't think it has anything to do with my changes, and locally the units tests runs just fine

@mikehostetler
Copy link
Copy Markdown
Contributor

@sezaru flaky test - I'm digging into it

@mikehostetler mikehostetler added the ready_to_merge No blocking review findings remain; PR is merge-clean label Apr 18, 2026
@sezaru
Copy link
Copy Markdown
Contributor Author

sezaru commented Apr 19, 2026

Oh, seems like the snapshot.json updated upstream and created a conflict, should I regenerate it?

@mikehostetler mikehostetler added needs_work Blocking findings or failing validation remain and removed ready_to_merge No blocking review findings remain; PR is merge-clean labels Apr 19, 2026
@mikehostetler mikehostetler added ready_to_merge No blocking review findings remain; PR is merge-clean and removed needs_work Blocking findings or failing validation remain labels Apr 19, 2026
@mikehostetler mikehostetler merged commit e55e9f1 into agentjido:main Apr 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready_to_merge No blocking review findings remain; PR is merge-clean

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Can't create custom rerank providers because of llmdb schema

2 participants