Use best lap time as tiebreaker for same-time finishes#527
Merged
agateau merged 1 commit intoagateau:masterfrom Apr 18, 2026
Merged
Use best lap time as tiebreaker for same-time finishes#527agateau merged 1 commit intoagateau:masterfrom
agateau merged 1 commit intoagateau:masterfrom
Conversation
Owner
|
Hi Evan, thanks for this fix. Looks like a very rare edge case. Does it happen often to you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #468
When two racers finish with the exact same total time,
compareRaceDistances()returns 0 (equal). This causes inconsistent ranking between the HUD (which counts racers ahead via iteration) and the results screen (which sorts racers, reordering ties unpredictably).Added a best-lap-time tiebreaker: when total times are equal, the racer with the faster best lap is ranked higher. This gives a deterministic result regardless of sort stability or array order.