Skip to content

Commit d330520

Browse files
committed
Make it work on non-sap module unit test examples
and correctly skip the FP case
1 parent 5bc5eb3 commit d330520

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

javascript/frameworks/ui5/src/UI5LogInjection/UI5LogsToHttp.ql

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,7 @@ class UI5LogEntryToHttp extends TaintTracking::Configuration {
8888
) {
8989
exists(UI5LogInjectionConfiguration cfg |
9090
cfg.isAdditionalFlowStep(start, end) and
91-
preState = "not-logged-not-accessed" and
92-
postState = "logged-not-accessed"
91+
preState = postState
9392
)
9493
or
9594
inSameWebApp(start.getFile(), end.getFile()) and
@@ -99,7 +98,7 @@ class UI5LogEntryToHttp extends TaintTracking::Configuration {
9998
.getACall()
10099
.getAnArgument() and
101100
end = ModelOutput::getATypeNode("SapLogEntries").asSource() and
102-
preState = "logged-not-accessed" and
101+
preState = "not-logged-not-accessed" and
103102
postState = "logged-and-accessed"
104103
}
105104

@@ -130,14 +129,7 @@ module UI5LogEntryToHttp implements DataFlow::ConfigSig {
130129

131130
import DataFlow::PathGraph
132131

133-
// import UI5LogEntryToHttpFlow::PathGraph
134-
module UI5LogEntryToHttpFlow = TaintTracking::Global<UI5LogEntryToHttp>;
135-
136132
from UI5LogEntryToHttp cfg, DataFlow::PathNode source, DataFlow::PathNode sink
137133
where cfg.hasFlowPath(source, sink)
138134
select sink, source, sink, "Outbound network request depends on $@ log data.", source,
139135
"user-provided"
140-
// from UI5LogEntryToHttpFlow::PathNode source, UI5LogEntryToHttpFlow::PathNode sink
141-
// where UI5LogEntryToHttpFlow::flowPath(source, sink)
142-
// select sink, source, sink, "Outbound network request depends on $@ log data.", source,
143-
// "user-provided"

0 commit comments

Comments
 (0)