Skip to content

Commit 5bc5eb3

Browse files
committed
Add back UI5LogInjectionConfiguration.isAdditionalTaintStep
1 parent 77f0d9a commit 5bc5eb3

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

javascript/frameworks/ui5/src/UI5LogInjection/UI5LogsToHttp.ql

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,9 @@ class LogListener extends DataFlow::Node {
6969
}
7070

7171
class UI5LogEntryFlowState extends DataFlow::FlowLabel {
72-
UI5LogEntryFlowState() { this = ["not-logged-not-accessed", "logged-and-accessed"] }
72+
UI5LogEntryFlowState() {
73+
this = ["not-logged-not-accessed", "logged-not-accessed", "logged-and-accessed"]
74+
}
7375
}
7476

7577
class UI5LogEntryToHttp extends TaintTracking::Configuration {
@@ -84,14 +86,20 @@ class UI5LogEntryToHttp extends TaintTracking::Configuration {
8486
DataFlow::Node start, DataFlow::Node end, DataFlow::FlowLabel preState,
8587
DataFlow::FlowLabel postState
8688
) {
89+
exists(UI5LogInjectionConfiguration cfg |
90+
cfg.isAdditionalFlowStep(start, end) and
91+
preState = "not-logged-not-accessed" and
92+
postState = "logged-not-accessed"
93+
)
94+
or
8795
inSameWebApp(start.getFile(), end.getFile()) and
8896
start =
8997
ModelOutput::getATypeNode("SapLogger")
9098
.getMember(["debug", "error", "fatal", "info", "trace", "warning"])
9199
.getACall()
92100
.getAnArgument() and
93101
end = ModelOutput::getATypeNode("SapLogEntries").asSource() and
94-
preState = "not-logged-not-accessed" and
102+
preState = "logged-not-accessed" and
95103
postState = "logged-and-accessed"
96104
}
97105

0 commit comments

Comments
 (0)