Skip to content

Comments

adds min/max empty lines after document start/end#393

Draft
wookietreiber wants to merge 2 commits intoadrienverge:masterfrom
idiv-biodiversity:document/empty-lines
Draft

adds min/max empty lines after document start/end#393
wookietreiber wants to merge 2 commits intoadrienverge:masterfrom
idiv-biodiversity:document/empty-lines

Conversation

@wookietreiber
Copy link

@adrienverge What do you think?

Note: This currently only includes the changes to document start. Will do the changes for document end and documentation later, based on your feedback.


fixes #340

@wookietreiber wookietreiber force-pushed the document/empty-lines branch 3 times, most recently from 5622fb9 to 4c86d3f Compare July 5, 2021 09:46
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 97.528% when pulling 4c86d3f on idiv-biodiversity:document/empty-lines into 4374490 on adrienverge:master.

Copy link
Owner

@adrienverge adrienverge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Christian,

This looks good!
I have a few remarks, please see my comments below.

Also, can you add a few more test cases:

  • For a document which just contains ---, nothing more?
  • In conjunction with empty-lines?
    For example, {empty-lines: {max: 1}, document-start: {min-empty-lines-after: 2} should report problems for , \n and \n\n.
  • Are there other corner cases that I didn't think of?

This currently only includes the changes to document start. Will do the changes for document end and documentation later, based on your feedback.

OK

@wookietreiber wookietreiber force-pushed the document/empty-lines branch from 4c86d3f to c9c6bdc Compare July 13, 2021 09:19
@wookietreiber
Copy link
Author

@adrienverge Thanks for the review. I'm gonna do the rest of the work, likely spread over the next couple of days. When I'm done, I'm going to remove the draft status and ping you for another review (dunno if removing the draft issues a notification, maybe re-requesting a review does).

Copy link
Owner

@adrienverge adrienverge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't know about removing the draft status, but any message or comment will get me notified (however I'll may be in vacations so please accept some delay in my review...)

@wookietreiber wookietreiber force-pushed the document/empty-lines branch 4 times, most recently from e7fef28 to 8d31c7d Compare July 14, 2021 06:57
@wookietreiber wookietreiber force-pushed the document/empty-lines branch from 8d31c7d to 88d302e Compare July 30, 2021 13:42
@wookietreiber wookietreiber changed the title [document-start] adds min/max empty lines after document start/end adds min/max empty lines after document start/end Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

exact number of empty lines for document start/end

3 participants