adds min/max empty lines after document start/end#393
adds min/max empty lines after document start/end#393wookietreiber wants to merge 2 commits intoadrienverge:masterfrom
Conversation
5622fb9 to
4c86d3f
Compare
adrienverge
left a comment
There was a problem hiding this comment.
Hello Christian,
This looks good!
I have a few remarks, please see my comments below.
Also, can you add a few more test cases:
- For a document which just contains
---, nothing more? - In conjunction with
empty-lines?
For example,{empty-lines: {max: 1}, document-start: {min-empty-lines-after: 2}should report problems for,\nand\n\n. - Are there other corner cases that I didn't think of?
This currently only includes the changes to document start. Will do the changes for document end and documentation later, based on your feedback.
OK
4c86d3f to
c9c6bdc
Compare
|
@adrienverge Thanks for the review. I'm gonna do the rest of the work, likely spread over the next couple of days. When I'm done, I'm going to remove the draft status and ping you for another review (dunno if removing the draft issues a notification, maybe re-requesting a review does). |
adrienverge
left a comment
There was a problem hiding this comment.
Thanks! I don't know about removing the draft status, but any message or comment will get me notified (however I'll may be in vacations so please accept some delay in my review...)
e7fef28 to
8d31c7d
Compare
8d31c7d to
88d302e
Compare
@adrienverge What do you think?
Note: This currently only includes the changes to document start. Will do the changes for document end and documentation later, based on your feedback.
fixes #340