remove event prefix from top-level keys in GoogleTagManager adapter#446
Open
opposable-crumbs wants to merge 1 commit intoadopted-ember-addons:mainfrom
Open
remove event prefix from top-level keys in GoogleTagManager adapter#446opposable-crumbs wants to merge 1 commit intoadopted-ember-addons:mainfrom
event prefix from top-level keys in GoogleTagManager adapter#446opposable-crumbs wants to merge 1 commit intoadopted-ember-addons:mainfrom
Conversation
|
It would be really great to see this merged. Is this library still maintained? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to this PR which added a deprecation for the prefixing behavior in the GTM adapter. This PR removes the actual code as well as the deprecation, and updates the relevant tests. It also adds an assertion that actually tests the
dataLayer.pushfunctionality in the adapter.Original Issue